Skip to content

Tests: Unregister custom post types in getPostsByAuthorSql.php - #15097

Closed
rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-post-getpostsbyauthorsql
Closed

Tests: Unregister custom post types in getPostsByAuthorSql.php#15097
rejaulalomkhan wants to merge 1 commit into
WordPress:trunkfrom
rejaulalomkhan:tests/65893-isolate-post-getpostsbyauthorsql

Conversation

@rejaulalomkhan

@rejaulalomkhan rejaulalomkhan commented Oct 28, 2026

Copy link
Copy Markdown

Description

In tests/phpunit/tests/post/getPostsByAuthorSql.php, register_post_type() is used across tests (test_multiple_post_types and test_user_has_access_only_to_private_posts_for_certain_post_types) to register custom post types 'foo', 'bar', and 'baz'.

While the tests call _unregister_post_type() at the end of their methods, any assertion failure before that point leaves these custom post types registered in the global $wp_post_types array, leaking state into subsequent tests.

This PR adds a dedicated tear_down() method in Tests_Post_GetPostsByAuthorSql to unregister 'foo', 'bar', and 'baz' via unregister_post_type(), ensuring complete test isolation.

Trac ticket: https://core.trac.wordpress.org/ticket/65893

This pull request modifies test files only.

Summary of Changes

  • Added tear_down() method in Tests_Post_GetPostsByAuthorSql within tests/phpunit/tests/post/getPostsByAuthorSql.php unregistering 'foo', 'bar', and 'baz'.

Test Coverage

  • Verified locally via vendor/bin/phpunit --filter Tests_Post_GetPostsByAuthorSql (16 tests, 21 assertions: all passed).
  • Ran PHPCS via vendor/bin/phpcs tests/phpunit/tests/post/getPostsByAuthorSql.php (0 errors, 0 warnings).

Use of AI Tools

  • Tool: Antigravity
  • Model: Gemini 2.5 Pro
  • Scope: Identifying test isolation leaks in getPostsByAuthorSql.php and drafting teardown cleanup.

@github-actions

github-actions Bot commented Oct 28, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rejaulalomkhan.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@lancewillett

lancewillett commented Oct 31, 2026

Copy link
Copy Markdown
Member

The added cleanup for foo, bar, baz repeats the Core test harness’s registry reset before each test. These registrations do not opt out of that reset, and no existing consumer is shown to fail before it. Closing this cleanup-only proposal as redundant; the existing behavioral tests remain unchanged.

The inherited reset runs in WP_UnitTestCase_Base::set_up().

Thanks for working on test isolation. We can reopen this if an existing test or fixture fails without the cleanup and passes with it under the same environment and order.

AI review · gpt-6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rejaulalomkhan @lancewillett @mukeshpanchal27